Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Allow google cloud storage locations for cached_path #5173

Merged
merged 5 commits into from
May 3, 2021

Conversation

jmelot
Copy link
Contributor

@jmelot jmelot commented May 3, 2021

Fixes #5150

Changes proposed in this pull request:

  • Allow google cloud storage locations for cached_path

@jmelot jmelot changed the title Issue 5150 Allow google cloud storage locations for cached_path May 3, 2021
@epwalsh epwalsh self-requested a review May 3, 2021 16:50
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Thanks @jmelot :)

setup.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@epwalsh epwalsh enabled auto-merge (squash) May 3, 2021 17:38
@epwalsh epwalsh merged commit 01b232f into allenai:main May 3, 2021
dirkgr pushed a commit that referenced this pull request May 10, 2021
* Allow google cloud storage locations for cached_path

* Update changelog

* Add missing quotes

* Apply suggestions from code review

Co-authored-by: Pete <[email protected]>
Co-authored-by: Pete <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cached_path should handle "gs://" (Google Cloud Storage) URLs just like it does for "s3://" or "hf://"
2 participants